Changeset 14480

Timestamp:

01/17/08 15:16:51 (11 months ago)

Author:

rambo

Message:

smarter, configurable get_icon and get_create_icon

Files:

• trunk/midcom/midcom.helper.reflector/config/config.inc (modified) (2 diffs)
• trunk/midcom/midcom.helper.reflector/reflector.php (modified) (3 diffs)

trunk/midcom/midcom.helper.reflector/config/config.inc

@@ -27 +27 @@
-    'midgard_language',
-    'midgard_quota',
+    /* members should not be root classes by MgSchema, workaround a bug */
+    'midgard_member',
-    /* These use GUID to link to many parents */
-    'net_nemein_tag_link',
@@ -61 +63 @@
-(
-),
+// keyed by icon, values are arrays of classes (__default__ marking the default icon) names, used to determine icon to use for object
+'object_icon_magic' => array
+(
+    'document.png' => array
+    (
+        '__default__',
+    ),
+    'stock_folder.png' => array
+    (
+        'midgard_topic',
+        'midgard_snippetdir',
+        'midgard_style',
+        'midgard_page',
+        'net_nemein_discussion_thread',
+        'org_openpsa_products_product_group',
+    ),
+    'stock_people.png' => array
+    (
+        'net_nehmer_buddylist_entry_db',
+        'org_openpsa_campaign',
+    ),
+    'stock_news.png' => array
+    (
+        'org_openpsa_notifications_notification',
+        'net_nemein_rss_feed',
+    ),
+    'locale.png' => array
+    (
+        'org_routamc_positioning_country',
+    ),
+    'geoclue.png' => array
+    (
+        'org_routamc_positioning_location',
+    ),
+    'stock-discussion.png' => array
+    (
+        'net_nemein_discussion_post',
+    ),
+    'package.png' => array
+    (
+        'org_openpsa_products_product',
+    ),
+    'camera.png' => array
+    (
+        'org_routamc_photostream_photo',
+    ),
+),
+// This works just like object_icon_magic
+'create_type_magic' => array
+(
+    'new-text.png' => array
+    (
+        '__default__',
+    ),
+    'new-dir.png' => array
+    (
+        'midgard_topic',
+        'midgard_page',
+        'midgard_snippetdir',
+        'midgard_style',
+        'net_nemein_discussion_thread',
+    ),
+    'stock_people-new.png' => array
+    (
+        'org_openpsa_campaign',
+    ),
+),
-
-'experimental_root_class_detection' => false,
-

trunk/midcom/midcom.helper.reflector/reflector.php

@@ -343 +343 @@
-    function get_create_icon($type)
-    {
-
-
-
-
-
-
-
-
-
-
-
-
-
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
-                $icon = 'stock_people-new.png';
-                break;
-
-
-
-
+
+
-                $icon = 'stock_person-new.png';
-                break;
-
-
-
+
-                $icon = 'stock_event_new.png';
-                break;
+
+            // Config default value 
+            case (isset($config_icon_map['__default__'])):
+                $icon = $config_icon_map['__default__'];
+                break;
+            // Fallback default value
-            default:
-                $icon = 'new-text.png';
@@ -378 +395 @@
-    function get_object_icon(&$obj)
-    {
-        // Check against static calling
-        if (   !isset($this->mgdschema_class)
-            || empty($this->mgdschema_class))
-        {
-            debug_push_class(__CLASS__, __FUNCTION__);
-            debug_add('May not be called statically', MIDCOM_LOG_ERROR);
-            debug_pop();
-            return false;
-        }
-
-        debug_push_class(__CLASS__, __FUNCTION__);
-        $properties = get_object_vars($obj);
-        if (empty($properties))
-        {
+            debug_push_class(__CLASS__, __FUNCTION__);
-            debug_add("Could not list object properties, aborting", MIDCOM_LOG_ERROR);
-            debug_pop();
-            return false;
-        }
-
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
-        switch(true)
-        {
+            // object knows it's icon, how handy!
-                case (method_exists($obj,'get_icon')):
-                        $icon = $obj->get_icon();
-                        break;
-
-
-
+
+
+
+
+
+
+
+
+
+
+
-                $icon = 'stock_person.png';
-                break;
-
-
-
-
-
-
-
-
-
-
-
-
+
-                $icon='stock_event.png';
-                break;
-
-
-
-
-
-
+
+
-                $icon='stock_people.png';
-                break;
@@ -432 +449 @@
-                $icon='stock_internet.png';
-                break;
-            case (is_a($obj, 'midgard_pageelement')):
-            case (is_a($obj, 'midgard_element')):
-                $icon = 'text-x-generic-template.png';
-                break;
-            case (is_a($obj, 'org_openpsa_notifications_notification')):
-            case (is_a($obj, 'net_nemein_rss_feed')):
-                $icon = 'stock_news.png';
-                break;
-            case (is_a($obj, 'org_routamc_positioning_country')):
-                $icon = 'locale.png';
-                break;
-            case (is_a($obj, 'org_routamc_positioning_location')):
-                $icon = 'geoclue.png';
-                break;
-            case (is_a($obj, 'net_nemein_discussion_post')):
-                $icon='stock-discussion.png';
-                break;
-            case (is_a($obj, 'org_openpsa_products_product')):
-                $icon='package.png';
-                break;
-            case (is_a($obj, 'org_routamc_photostream_photo')):
-                $icon='camera.png';
-                break;
-            case (is_a($obj, 'midgard_snippet')):
-                $icon='script.png';
-                break;
+            case (strpos($object_class, 'element') !== false):
+                $icon = 'text-x-generic-template.png';
+                break;
+
+            // Config default value 
+            case (isset($config_icon_map['__default__'])):
+                $icon = $config_icon_map['__default__'];
+                break;
+            // Fallback default value
-            default:
-                $icon = 'document.png';
-
-
-
+
+
+
+
+
-        debug_pop();
-        return $icon;