Changeset 14784

Timestamp:

02/07/08 13:18:47 (10 months ago)

Author:

bergie

Message:

Don't use unnecessary OR groups in Asgard navigation. It can be harmful in 1.9

Files:

• trunk/midcom/midcom.helper.reflector/reflector_tree.php (modified) (3 diffs)

trunk/midcom/midcom.helper.reflector/reflector_tree.php

@@ -541 +541 @@
-        // Figure out constraint to use to get child objects
-        // TODO: Review this code
-        $qb->begin_group('OR');
-        $ref = new midgard_reflection_property($schema_type);
-        $upfield = midgard_object_class::get_property_up($schema_type);
+        
+        if (   !empty($upfield)
+            && !empty($parentfield))
+        {
+            $qb->begin_group('OR');
+        }
-
-        if (!empty($upfield))
@@ -569 +574 @@
-                    debug_add("Do not know how to handle upfield '{$upfield}' has type {$uptype}", MIDCOM_LOG_ERROR);
-                    debug_pop();
-
+
+
+
+
+
-                    return false;
-            }
@@ -596 +605 @@
-                    debug_add("Do not know how to handle parentfield '{$parentfield}' has type {$parenttype}", MIDCOM_LOG_INFO);
-                    debug_pop();
-
+
+
+
+
+
-                    return false;
-            }
-        }
-
+
+
+
+
+
+
-        // TODO: /Review this code
-