Changeset 15358

Show
Ignore:
Timestamp:
03/04/08 10:12:38 (6 months ago)
Author:
rambo
Message:

typo fix & bulletproofing: never remove a field from field list without making sure it is removed from field_order array as well

Files:

Legend:

Unmodified
Added
Removed
Modified
Copied
Moved

  • branches/MidCOM_2_8/midcom.admin.user/handler/group/edit.php

    r14775 r15358  
    9797        $qb = midcom_db_member::new_query_builder(); 
    9898        $qb->add_constraint('gid', '=', $this->_group->id); 
    99         if ($qb->count_unchecked() > $this->_config->get('list_users_max')) 
     99        if (   $qb->count_unchecked() > $this->_config->get('list_users_max') 
     100            && isset($this->_schemadb['default']->fields['persons'])) 
    100101        { 
    101102            unset($this->_schemadb['default']->fields['persons']); 
    102         } 
     103            $field_order_key = array_search('persons', $this->_schemadb['default']->field_order); 
     104            if ($field_order_key !== false) 
     105            { 
     106                unset($this->_schemadb['default']->field_order[$field_order_key]); 
     107            } 
     108        } 
     109        unset($qb); 
    103110         
    104111        $this->_controller =& midcom_helper_datamanager2_controller::create('simple'); 

  • branches/MidCOM_2_8/midcom.helper.datamanager2/formmanager.php

    r15356 r15358  
    226226            if (!isset($this->_schema->fields[$name])) 
    227227            { 
    228                 debug_push_class(__CLASS__, __FUNCTION); 
     228                debug_push_class(__CLASS__, __FUNCTION__); 
    229229                debug_add("Field {$name} is not present in \$this->_schema->fields (read from \$this->_schema->field_order)", MIDCOM_LOG_ERROR); 
    230230                debug_pop();