Changeset 17887

Timestamp:

10/03/08 12:09:56 (2 months ago)

Author:

rambo

Message:

added some important notes about caching and made flushing of output to happen before we start writing the cache files so user does not have to wait for the writes to complete

Files:

• branches/MidCOM_2_8/midcom.core/midcom/services/cache/module/content.php (modified) (3 diffs)

branches/MidCOM_2_8/midcom.core/midcom/services/cache/module/content.php

@@ -955 +955 @@
-
-        $cache_data = ob_get_contents();
+        /**
+         * WARNING: 
+         *   From here on anything added to content is not included in cached
+         *   data, so make sure nothing content-wise is added after this 
+         */
-
-        // Generate E-Tag header.
@@ -975 +980 @@
-        $this->register_sent_header($header);
-        $this->_complete_sent_headers($cache_data);
+
+        // If-Modified-Since / If-None-Match checks, if no match, flush the output.
+        if (! $this->_check_not_modified($this->_last_modified, $etag))
+        {
+            ob_end_flush();
+            $this->_obrunning = false;
+        }
+
+        /**
+         * WARNING: 
+         *   Stuff below here is executed *after* we have flushed output,
+         *   so here we should only write out our caches but do nothing else
+         */
-
-        if ($this->_uncached)
@@ -991 +1009 @@
-            $this->write_meta_cache($content_id, $etag);
-            $this->_data_cache->put($content_id, $cache_data);
-        }
-
-        // Finish caching.
-        // If-Modified-Since / If-None-Match checks, if no match, flush the output.
-        if (! $this->_check_not_modified($this->_last_modified, $etag))
-        {
-            ob_end_flush();
-            $this->_obrunning = false;
-        }
-    }