Ticket #70 (closed task: fixed)

Opened 1 year ago

Last modified 9 hours ago

Remove Datamanager 1 as core dependency

Reported by: bergie Assigned to: bergie
Priority: major Milestone: 8.09.3 Ragnaroek
Component: MidCOM component Version: 1.8 Thor
Keywords: Cc:

Description (Last modified by bergie)

All dependencies for DM1 should be removed from MidCOM core components, and other components depending on it marked clearly so.

Change History

03/13/08 14:22:13 changed by bergie

  • milestone changed from MidCOM 3.0 to MidCOM 2.9.

09/30/08 14:11:35 changed by bergie

  • milestone changed from MidCOM 2.9 to 8.09 Ragnaroek.

10/02/08 02:57:08 changed by flack

This would effectively mean that half of OpenPSA would have to be rewritten. Since OpenPSA works quite well with Ragnaroek, it would be nice to be able to keep it, but changing everything to DM2 will take lots of time

10/07/08 16:23:47 changed by bergie

  • owner changed from tarjei to adrenalin.
  • version set to 1.8 Thor.

10/09/08 23:37:08 changed by bergie

(In [18092]) Remove some unused DM1 configs, refs #70

10/09/08 23:38:09 changed by bergie

Mentions in MidCOM core:

midcom.core/midcom/baseclasses/components/interface.php: *             $datamanager = new midcom_helper_datamanager($config->get('schemadb'));
midcom.core/midcom/baseclasses/components/request_admin.php:        $data['datamanager'] = new midcom_helper_datamanager($this->_handler['schemadb']);
midcom.core/midcom/baseclasses/components/request_admin.php:     * @param midcom_helper_datamanager $datamanager A reference(!) to the datamanager handling the request.
midcom.core/midcom/core/handler/configdm.php:        $data['datamanager'] = new midcom_helper_datamanager($this->_master->_handler['schemadb']);
midcom.core/midcom/core/handler/configdm.php:     * @param midcom_helper_datamanager $datamanager A reference(!) to the datamanager handling the request.
midcom.core/midcom/helper/mailtemplate.php:                if (is_a($value, "midcom_helper_datamanager"))
midcom.core/midcom/helper/mailtemplate.php:     * @param midcom_helper_datamanager $dm        A fully initialized Datamanager instance.
midcom.core/midcom/services/indexer/document/datamanager.php: * @see midcom_helper_datamanager
midcom.core/midcom/services/indexer/document/datamanager.php:     * @var midcom_helper_datamanager
midcom.core/midcom/services/indexer/document/datamanager.php:     * @param midcom_helper_datamanager $datamanager The fully initialized datamanager instance to use
midcom.core/midcom/services/indexer/document.php:     * @param midcom_helper_datamanager $datamanager A reference to the
midcom.core/midcom/services/indexer.php:     * - Datamangager 1 Instances (midcom_helper_datamanager)
midcom.core/midcom/services/indexer.php:        if (is_a($object, 'midcom_helper_datamanager'))
midcom.core/midcom/services/indexer.php:        if (is_a($object, 'midcom_helper_datamanager'))
midcom.core/midcom/baseclasses/components/request_admin.php: *     handler), check out the class midcom_core_handle
r_configdm.
midcom.core/midcom/core/handler/configdm.php: *     'handler' => Array ('midcom_core_handler_configdm', 'configdm')

Components using DM1 for configuration:

  • de.linkm.sitemap
  • net.nehmer.blog
  • net.nehmer.comments
  • net.nehmer.mail
  • net.nehmer.publications
  • net.nehmer.static
  • net.nemein.discussion
  • net.nemein.downloads
  • net.nemein.lastupdates
  • net.nemein.organizations
  • net.nemein.quickpoll
  • net.nemein.reservations
  • net.nemein.shoppingcart
  • net.nemein.teams
  • net.nemein.updatenotification
  • org.openpsa.directmarketing
  • org.openpsa.mypage
  • org.openpsa.products
  • scaffold

Components built on top of DM1

  • midgard.webdav.styles: is anybody using or maintaining this?
  • net.nemein.simpledb: this is actually an useful component, maybe a simpledb2 would be in order?
  • no.odindata.quickform: makes no sense to port as there is quickform2 which uses DM2 already

OpenPsa? components that flack and adrenalin seem to be porting to DM2

org.openpsa.calendar/midcom/interfaces.php:                $datamanager = new midcom_helper_datamanager($config->get('schemadb'));
org.openpsa.calendar/viewer.php:        $this->_datamanager = new midcom_helper_datamanager($schemadb);
org.openpsa.calendar/viewer.php:        if (array_key_exists('midcom_helper_datamanager_field_participants', $_POST))
org.openpsa.calendar/viewer.php:            $event->participants = $_POST['midcom_helper_datamanager_field_participants'];
org.openpsa.calendar/viewer.php:        if (array_key_exists('midcom_helper_datamanager_field_busy', $_POST))
org.openpsa.calendar/viewer.php:            $event->busy = $_POST['midcom_helper_datamanager_field_busy'];
org.openpsa.calendar/viewer.php:        if (array_key_exists('midcom_helper_datamanager_field_start', $_POST))
org.openpsa.calendar/viewer.php:            $event->start = strtotime($_POST['midcom_helper_datamanager_field_start']);
org.openpsa.calendar/viewer.php:        if (array_key_exists('midcom_helper_datamanager_field_end', $_POST))
org.openpsa.calendar/viewer.php:            $event->end = strtotime($_POST['midcom_helper_datamanager_field_end']);
org.openpsa.contacts/handler/group.php:        'group' => new midcom_helper_datamanager($this->_config->get('schemadb_group')),
org.openpsa.contacts/handler/group.php:        'notifications' => new midcom_helper_datamanager($this->_config->get('schemadb_notifications')),
org.openpsa.contacts/handler/group.php:            'acl' => new midcom_helper_datamanager($this->_config->get('schemadb_acl'))
org.openpsa.contacts/handler/person.php:            'person' => new midcom_helper_datamanager($this->_config->get('schemadb_person')),
org.openpsa.contacts/handler/person.php:            'acl' => new midcom_helper_datamanager($this->_config->get('schemadb_acl'))
org.openpsa.contacts/handler/person.php:        $this->_datamanagers['group'] = new midcom_helper_datamanager($this->_config->get('schemadb_group'));
org.openpsa.contacts/handler/person.php:                if (array_key_exists('midcom_helper_datamanager_submit', $_POST))
org.openpsa.contacts/handler/person.php:                if (array_key_exists('midcom_helper_datamanager_submit', $_POST))
org.openpsa.documents/handler/directory.php:        $this->_datamanagers['directory'] = new midcom_helper_datamanager($this->_config->get('schemadb_directory'));
org.openpsa.documents/handler/directory.php:        $this->_datamanagers['metadata'] = new midcom_helper_datamanager($this->_config->get('schemadb_metadata'));
org.openpsa.documents/handler/directory.php:        if (array_key_exists('midcom_helper_datamanager_field_extra', $_POST))
org.openpsa.documents/handler/directory.php:            $topic->name = midcom_generate_urlname_from_string($_POST['midcom_helper_datamanager_field_extra']);
org.openpsa.documents/handler/metadata.php:    $this->_datamanagers['metadata'] = new midcom_helper_datamanager($this->_config->get('schemadb_metadata'));
org.openpsa.documents/handler/metadata.php:                    && array_key_exists('midcom_helper_datamanager__document_delete', $_POST))
org.openpsa.documents/handler/search.php:    $this->_datamanagers['metadata'] = new midcom_helper_datamanager($this->_config->get('schemadb_metadata'));
org.openpsa.documents/handler/search.php:    $this->_datamanagers['metadata'] = new midcom_helper_datamanager($this->_config->get('schemadb_metadata'));
org.openpsa.documents/midcom/interfaces.php:                $datamanager = new midcom_helper_datamanager($config->get('schemadb_metadata'));
org.openpsa.imp/viewer.php:        $this->_request_data['datamanager'] = new midcom_helper_datamanager($schemadb);
org.openpsa.invoices/handler/delete.php:        $this->_datamanager = new midcom_helper_datamanager($schemadb_snippet);
org.openpsa.invoices/handler/edit.php:        $this->_datamanager = new midcom_helper_datamanager($schemadb_snippet);
org.openpsa.projects/handler/hours/action.php:            'hours' => new midcom_helper_datamanager($this->_config->get('schemadb_hours'))
org.openpsa.projects/handler/hours/action.php:        $this->_datamanagers[$type] = new midcom_helper_datamanager($schemadb);
org.openpsa.projects/handler/hours/action.php:            $hour_report->task = $_POST['midcom_helper_datamanager_field_task'];
org.openpsa.projects/handler/hours/action.php:        if (   array_key_exists('midcom_helper_datamanager_field_invoiceable', $_REQUEST)
org.openpsa.projects/handler/hours/action.php:            && !empty($_REQUEST['midcom_helper_datamanager_field_invoiceable']))
org.openpsa.projects/handler/hours/action.php:                $this->_request_data['hour_report'] = $this->_load_hours($_POST['midcom_helper_datamanager_field_guid']);
org.openpsa.projects/handler/hours/list.php:            'hours' => new midcom_helper_datamanager($this->_config->get('schemadb_hours'))
org.openpsa.projects/handler/hours/list.php:        $_REQUEST['midcom_helper_datamanager_submit'] = true;
org.openpsa.projects/handler/project/action.php:            'project' => new midcom_helper_datamanager($this->_config->get('schemadb_project'))
org.openpsa.projects/handler/project/list.php:            'project' => new midcom_helper_datamanager($this->_config->get('schemadb_project'))
org.openpsa.projects/handler/project/new.php:            'project' => new midcom_helper_datamanager($this->_config->get('schemadb_project'))
org.openpsa.projects/handler/task/action.php:            'task' => new midcom_helper_datamanager($this->_config->get('schemadb_task'))
org.openpsa.projects/handler/task/new.php:            'task' => new midcom_helper_datamanager($this->_config->get('schemadb_task'))
org.openpsa.sales/handler/edit.php:        $this->_datamanagers[$type] = new midcom_helper_datamanager($schemadb);
org.openpsa.sales/handler/list.php:        $this->_datamanagers[$type] = new midcom_helper_datamanager($schemadb);

10/10/08 19:40:46 changed by flack

(In [18119]) remove the last traces of DM1 from o.o.projects, refs #70

10/13/08 10:23:19 changed by bergie

  • milestone changed from 8.09 Ragnaroek to 8.09.2 Ragnaroek.

10/20/08 10:47:43 changed by bergie

  • milestone changed from 8.09.2 Ragnaroek to 8.09.3 Ragnaroek.

While some good progress has been done, this will not be completed in .2 schedule.

10/28/08 10:15:53 changed by bergie

(In [18468]) Forward-port DM2 config, refs #70, fixes #426

11/19/08 12:46:48 changed by bergie

(In [18862]) Don't install DM1 unless it comes as package dependency, refs #70

11/19/08 12:47:05 changed by bergie

(In [18863]) Update documentation to utilize DM2, refs #70

11/19/08 12:53:19 changed by bergie

(In [18866]) Clean and isolate indexer DM1 references, refs #70

11/19/08 13:35:07 changed by bergie

(In [18868]) Log warning on DM1 configdm usage, refs #70

11/19/08 14:34:36 changed by bergie

(In [18873]) Remove unused DM1 config schema, refs #70

11/19/08 14:49:44 changed by bergie

(In [18875]) Get rid of DM1 schemas in scaffold, refs #70

11/19/08 15:25:13 changed by bergie

(In [18876]) Update obsolete DM1 config dependencies, refs #70

11/19/08 15:27:33 changed by bergie

  • owner changed from adrenalin to hirvinen.
  • description changed.

Status update: Core is now clean of DM1 references (isolated incidents in indexer and configdm are left intentionally)

Of core components, the following still use DM1 for configuration:

  • de.linkm.sitemap
  • net.nehmer.comments

Of contrib components, the following still use DM1 for configuration:

  • net.nehmer.mail
  • net.nehmer.publications
  • net.nemein.discussion
  • net.nemein.downloads
  • net.nemein.lastupdates
  • net.nemein.organizations
  • net.nemein.quickpoll
  • net.nemein.reservations
  • net.nemein.shoppingcart
  • net.nemein.updatenotification
  • org.openpsa.calendar
  • org.openpsa.directmarketing
  • org.openpsa.products

In addition, there are the following components using DM1:

  • net.nemein.simpledb
  • no.odindata.quickform
  • org.openpsa.contacts
  • org.openpsa.documents
  • org.openpsa.imp
  • org.openpsa.invoices
  • org.openpsa.sales

Before .3 we should remove all DM1 configs from core components.

Contrib components and components using DM1 have been marked to depend on dm1, and it is no longer automatically installed by midgard-data. This means that DM1 will be there only if you install a component that uses it.

In addition, configdm now logs a warning when called.

11/19/08 15:37:37 changed by bergie

  • summary changed from Remove Datamanager 1 to Remove Datamanager 1 as core dependency.

11/24/08 20:05:22 changed by flack

(In [18966]) rudimentary conversion to DM2, refs #70

12/01/08 12:53:02 changed by bergie

(In [19117]) Use DM2 for config, refs #70

12/01/08 13:15:43 changed by bergie

  • owner changed from hirvinen to bergie.

12/01/08 13:16:55 changed by bergie

  • status changed from new to closed.
  • resolution set to fixed.

(In [19119]) Use DM2 for config, fixes #70